Adapt library to pymodbus 3.10.0

[Djcd]

Hi together,

I don't contribute that much code 😄 and i dunno if i understood every piece of your helpful library.

With pymodbus 3.10.0 there were some changes which were introduced with this PR pymodbus-dev/pymodbus#2600.

Especially those should be interesting for this project:

• ModbusSlaveContext replaced by ModbusDeviceContext
• slave=, slaves= replaced by device_id=, device_ids=

i tried my best to adapt this into your code, but please have another look into it. I could check it with my home assistant instance and this addon https://github.com/pail23/stiebel_eltron_isg_component and it seems to work again 👍

Kind regards,
David

[pail23]

Many thanks for the changes.

1. Please update the modbus library version in pyproject.toml: "pymodbus>=3.10.0",
2. Please run the ./scripts/gen.sh script to update the generated files

The rest looks good to me.

[Djcd]

thanks for the additions @pail23, the ./scripts/gen.sh did some strange formatting, hopefully thats okay

[pail23]

@ThyMYthOS This is an important fix for the stiebel eltron isg custom component which was brocken in the last homeassistant update.

How can I support a fast merge of this PR and a subsequent release of this library?

[ThyMYthOS]

WTF? Why would they (pymodbus) introduce a breaking change by only updating the minor version number?

The changes in pystiebeleltron.py seem to bei mainly style related. Could that be fixed in a separate PR?

[Djcd]

Hi @ThyMYthOS,

i reverted the style related stuff from pystiebeleltron.py. It seems for me that pymodbus does not follow the semantic version sheme... i will fix that test 😄

[Djcd]

merged with the new upstream version

[Djcd]

thanks for the fast reply and help @ThyMYthOS !

@pail23 i don't know how the next steps are. do we need an update of the component to force home assistant / hacs to pull the changes in the dependency?