Closed
Conversation
Fixes the function throwing an error when there are no code search results
Tiberriver256
force-pushed
the
bugfix/95--length-issue
branch
from
4285fd5 to
7357616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the robustness of the
searchCodefeature and its integration tests. The changes focus on enhancing error handling, ensuring data validation, and simplifying the code structure.Enhancements to error handling and data validation:
src/features/search/search-code/feature.ts: Added checks to validate the response from the search API, ensure required properties are present in the results, and handle different Azure DevOps URL formats. [1] [2] [3]Simplification of integration tests:
src/features/search/search-code/feature.spec.int.ts: Removed try-catch blocks and test skipping logic to streamline the test cases and focus on core assertions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]#95