-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add the words and lines modes to $diff-text
#7386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2451.4 KB |
| PR | 2453.9 KB |
Diff: ⬆️ Increase: +2.5 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.0/#7386
Type: feature | Category: widget
Release: 5.4.0
Add words and lines modes to diff-text widget
🔗 #7386
👥 Contributors: yaisog
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
|
Looks good, thank you @yaisog |
Similar to their implementation in the new
makepatchesoperator,$diff-text, using the same library, could also use thewordsandlinesmodes. I believe there are quite a few cases that will be more intelligible ifwordsmode were used. Similarly, highlighting whole lines may also be beneficial in some cases.This PR adds the same
diffLineWordModeanddiffPartsToCharsfunctions to$diff-textthat were also added tostrings.jsas part of the implementation for themakepatchesoperator.The documentation tiddler has also been completely overhauled to also allow for testing of the various options.
Closes #7358