Skip to content

fix: Warn if a hook function forgets return when it is of pipe mode #9519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
linonetwo wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Warn if a hook function forgets return when it is of pipe mode #9519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f67258
fix: Warn if a hook function forgets return when it is of pipe mode
linonetwo Dec 26, 2025
da84d7b
Update boot.js
linonetwo Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions boot/boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2735,7 +2735,12 @@ $tw.hooks.invokeHook = function(hookName /*, value,... */) {
var args = Array.prototype.slice.call(arguments,1);
if($tw.utils.hop($tw.hooks.names,hookName)) {
for(var i = 0; i < $tw.hooks.names[hookName].length; i++) {
var previousValue = args[0];
args[0] = $tw.hooks.names[hookName][i].apply(null,args);
// Warn if a hook function forgets return when it is of pipe mode
if(args[0] === undefined && previousValue !== undefined) {
console.warn("Hook '" + hookName + "' handler at index " + i + " returned undefined. Expected the handler to return the value for the next hook in the chain. Handler function:", $tw.hooks.names[hookName][i]);
}
}
}
return args[0];
Expand Down
Loading