-
Notifications
You must be signed in to change notification settings - Fork 13
Add warning about Windows installation failure to README #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
looks like they just bumped the julia version - i havent been able to downloaded it yet because im not sure its on the registry quite yet... but when it does, can you try to see if you still experience the build issue on a windows machine (im on a mac)? if you dont, i can change the tidierdb compats to only included 1.2 |
Unfortunately, the issue remains the same. Error with DuckDB v1.2.0
(The same error happens if I |
@digital-carver From what I've read in the prs, I think this is now solved with the 1.2.1 duckdb_jll released this morning Was wondering if you could try locally to see if this is the case for you? |
Well, my celebration emoji above may have been a bit premature 😕 There's no longer an installation failure, so that part of it is technically solved. Adding After adding them though, I tried a small test to make sure it actually works.
In both cases, the Julia process crashes with an Full `EXCEPTION_ACCESS_VIOLATION` when trying `DB.connect(DB.duckdb())` from Tidier
julia> using Tidier
I'm not sure if this is the same issue reoccurring in a different form, or if fixing the original issue exposed this new issue with DuckDB. If there are other tests you want me to run, or some other place to report this issue at, please let me know. |
Hmm this may have to do with the old version of tiderdb in tidier not being changed. Can you try in a dif env adding the TidierDB#compats (you prob won't be able to have tidier and that coexist because I think it's tagged as .8) branch and making sure that works? |
Nope, same issue unfortunately. Details
(@v1.11) pkg> activate --temp
Activating new project at `C:\Users\Sundar\AppData\Local\Temp\jl_0vLCEE`
|
That's unfortunate. I am wondering if we will have to wait for the update julia package since the compat still has 1.2.0
@digital-carver i just tried to add the compats branch locally and it failed. I think for the above reason. Hopefully, when the 1.2.1 package version is released it will work w the binary
|
By "julia package" here I assume you mean the DuckDB package? It does seem to list the compat as 1.2.0, but according to Julia's version specifier format, that means any 1.x.y version is allowed, right? Matching that interpretation, in all three environments (the one with Tidier.jl, the one with TidierDB.jl, and the one with TidierDB#compats), the Manifest listing shows:
so it seems 1.2.1 is already being pulled in. Checking
|
Searching for |
I did mean the DuckDB.jl package above, yes. The compat bounds always trip me up. Based on the issues I am running into, it would seem that having it as 1.2 When I have
I cannot install the compats branch at all.
When I change it to
but then i cant seem to install
but is that also did the issue you experienced go away when you used julia 1.10 and above? ALSO: huge thank you to you for working through this with me. I really appreciate it. |
All the above outputs have been from Julia 1.11. It seems that your results are from 1.10, maybe that's somehow be the reason for [email protected] failing to install? As mentioned in my comment above, DuckDB_jll v1.2.1 does get installed for me automatically (on 1.11). It's when I try to use it that the issues arise. Although, DuckDB_jll itself lists only Julia 1.6 (and above) as its requirement, so maybe it's not Julia's version itself, but one of the other packages in your environment that's restricting DuckDB_jll - could you try installing just TidierDB and [email protected] in a new temporary environment (eg. after
message was more informative about why only those are the possible versions!
I'm glad to be of help. It's the care and effort put into the Tidier ecosystem, by you and others, that keeps me motivated to try and get this working! |
So think I figured out the reason it was getting restricted because I was specifying the version to DuckDB_jll = "1.2.1" on branch i was experimenting with. Interesting when I installed TidierDB v.6.3 with [email protected] on google collab,
I was then able to open up a db, so unable to recreate the error you experienced above with Julia 1.10
|
Do you think you would be able to try the main branch again? I reverted back to the 1.0 and 1.0 fur duckdb and duckdb_jll AND the docs with UDFs still builds ... so if the main page gets rid of connection issue you had and the prior non compile issue, then i think its a happy medium to make sure the dust settle and TidierDB does cause install headaches for Tidier users |
If this is on Google Colab, that's to be expected isn't it, since Colab uses a Linux OS underneath? This seems to remain a Windows-only issue still.
I did
From my understanding, the
lines would still mean [1.x - 2.0) i.e. it still allows any DuckDB and DuckDB_jll version that's less than 2.0, as we discussed before. And the Manifest output when installing
But instead of doing that and restricting users of all OSs to an older DuckDB, we can maybe ask Windows users to manually restrict DuckDB to an older working version themselves. So, for now, please leave the main branch as it is, allowing any [1.x - 2.0) version of DuckDB, and I'll try manually restricting DuckDB to versions less than 1.20 myself and see what works. (This idea just occurred to me while writing this post, and it's post-3AM here, so I'll try this experiment at some point tomorrow and reply back with the results!) |
Hmmm this is tricky. Thank you for all the details. I discovered this compat rule after the the push to main but this was good to know regardless . Were you able to load tidier at all ? With I'm wondering if this is a local issue for you? Or broader. I'm curious if people who originally experienced the failure are experiencing this new issue as well. |
I'll try this when I'm at my computer again.
I was wondering this as well. My Windows setup isn't anything unique or custom, so I can't readily think of a reason this would be specific to me, but it would still be good to know. If I understand https://github.com/TidierOrg/TidierDB.jl/blob/main/.github/workflows/CI.yml correctly, the CI for TidierDB runs only on Ubuntu Linux. If it's feasible to add Windows also as a CI target platform, the runtest action should be informative in this regard. |
If you can run tidier successfully, I think that would definitely make me inclined to keep 1.2.1 with a spot in the docs somewhere to help folks who are having duckdb troubles. (The other library Tulipia I learned the workaround from just moved to 1.2.1 ) That being said, would be happy about the ci test. CIs are very much not my skillset, so if you have the bandwidth or knowledge, would you be able to put in a PR on TidierDB with that change and we can run the test and see ? |
As discussed elsewhere, this adds a Warning message to let Windows users that installation failure is a known issue, and links them to the descriptive list of underlying packages.