grant write perms in yml for doc deployment#11
Merged
jdiaz97 merged 4 commits intoTidierOrg:mainfrom Feb 7, 2025
Merged
Conversation
Member
|
Thanks! I would suggest changing minimum Julia to 1.10 to be consistent with rest of Tidier ecosystem and because 1.10 is currently LTS version. |
Member
|
Ah I see, only for docs building 1.11 should be fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
As per Karandeeps' suggestion in the Slack thread, I added a permissions entry to Documentation.yml the way Documenter.jl's manual recommends.
While doing that, I also saw that the push branch's name was listed as
masterwhen this repo actually usesmain, so I changed that too.Also, the Julia version for doc building was being given as 1.9 - I don't see any reason to use an older version for documentation building, so I changed that to 1.11, since newer versions have better compile and loading times. Let me know if there's a reason to use v1.9 though, I can revert that particular commit.