This repository was archived by the owner on Jan 31, 2026. It is now read-only.
Closed
Conversation
Tienisto
reviewed
Jan 7, 2026
| import 'package:rhttp/src/rust/api/http.dart' show HttpMethod; | ||
| import 'package:rhttp/src/rust/api/websocket.dart' as rust; | ||
|
|
||
| class RhttpWebsocketClient { |
Owner
There was a problem hiding this comment.
Should be RhttpWebsocketConnection because it represents one single connection and cannot be reused.
| class RhttpWebsocketClient { | ||
| rust.WebSocketHandle _handle; | ||
|
|
||
| Stream<rust.RhttpWebSocketEvent> stream; |
Owner
There was a problem hiding this comment.
Maybe a private StreamController + exposing a Stream get => _streamController.stream would offer more flexibility.
But this is just implementation. The current API is fine.
Owner
|
I believe the stream should be a union type of |
Owner
|
Development moved to Codeberg: https://codeberg.org/Tienisto/rhttp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds rudimentary WebSocket support using
reqwest-websocket.This was requested in #72.
A few things are still missing:
flutter_rust_bridgeI am just opening this in order to hopefully gather some early feedback on the general API and whether the current approach seems to be fine overall.
The size increase of a "fat" APK seems to be around 0.5 MB (56.9 MB without WS and 57.4 MB with).