Use the clang-format pre-commit hook updated to the latest version#2039
Merged
kounelisagis merged 10 commits intomainfrom Feb 5, 2025
Merged
Use the clang-format pre-commit hook updated to the latest version#2039kounelisagis merged 10 commits intomainfrom
clang-format pre-commit hook updated to the latest version#2039kounelisagis merged 10 commits intomainfrom
Conversation
bfdba6d to
3c4e5cf
Compare
84b42e2 to
10a8ebf
Compare
Contributor
|
@kounelisagis @ihnorton can we perhaps have a discussion about syncing For those of us doing development on a single repo, whatever version the repo is using, the developer can easily switch to. For those of us doing multi-repo development -- and given that I'm aware of personally:
I'm all in favor of moving "into the future" -- just flagging the opportunity for a synchronize (unless there is such underway and I've missed it). |
10a8ebf to
d0d9790
Compare
clang-format pre-commit hook updated to the latest version
9c4326a to
4edd287
Compare
Member
Author
|
Rebased onto the main branch |
ihnorton
approved these changes
Feb 4, 2025
johnkerl
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, clang-format runs only on linux in a non-standard way:
TileDB-Py/.github/workflows/format.yml
Lines 15 to 19 in d447f12
It should be better to use the pypi edition of it: https://pypi.org/project/clang-format/ which also provides pre-commit hook and it's system agnostic.
This PR:
.clang-formatfile from TileDB-SOMA.clang-format.actions/setup-pythoninstances to version 5.actions/checkoutinstances to version 4.ruffandblackto their latest versions.[sc-43783]