Skip to content

Enable aarch64 wheel builds #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihnorton merged 9 commits into from
Jan 3, 2025
Merged

Enable aarch64 wheel builds #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5c3813
Enable aarch64 wheel builds
dudoslav Oct 14, 2024
c5b269e
Merge remote-tracking branch 'origin/dev' into db/sc-50707/aarch64
dudoslav Nov 22, 2024
dcdc749
Remove unused qemu setup
dudoslav Nov 22, 2024
9048f71
Build and test against 2.27.0-rc3
dudoslav Nov 22, 2024
5c6d946
Update arch selection for linux
dudoslav Nov 22, 2024
604aed8
Add logs to print what tiledb artifact is being downloaded
dudoslav Nov 27, 2024
f5a9074
Fix arm64 linux check
dudoslav Nov 27, 2024
e2c8ab4
Revert "Build and test against 2.27.0-rc3"
dudoslav Dec 3, 2024
600deaf
Merge remote-tracking branch 'origin/main' into db/sc-50707/aarch64
dudoslav Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
matrix:
buildplat:
- [ubuntu-22.04, manylinux_x86_64]
- [linux-arm64-ubuntu24, manylinux_aarch64]
Copy link
Member

@ihnorton ihnorton Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both of these?

- [macos-13, macosx_x86_64]
- [macos-14, macosx_arm64]
- [windows-2022, win_amd64]
Expand All @@ -39,7 +40,7 @@ jobs:
- uses: actions/checkout@v4

- name: "Brew setup on macOS" # x-ref c8e49ba8f8b9ce
if: ${{ startsWith(matrix.os, 'macos-') == true }}
if: ${{ startsWith(matrix.buildplat[0], 'macos-') == true }}
run: |
set -e pipefail
brew update
Expand Down Expand Up @@ -99,6 +100,7 @@ jobs:
- macos-14
- windows-2022
- ubuntu-22.04
- linux-arm64-ubuntu24
python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
runs-on: ${{ matrix.os }}
steps:
Expand Down
9 changes: 7 additions & 2 deletions cmake/DownloadTileDB.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ function(detect_artifact_name OUT_VAR)
SET(${OUT_VAR} TILEDB_MACOS-ARM64 PARENT_SCOPE)
endif()
else() # Linux
SET(${OUT_VAR} TILEDB_LINUX-X86_64 PARENT_SCOPE)
if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
SET(${OUT_VAR} TILEDB_LINUX-ARM64 PARENT_SCOPE)
else()
SET(${OUT_VAR} TILEDB_LINUX-X86_64 PARENT_SCOPE)
endif()
endif()
endfunction()

Expand All @@ -113,6 +117,7 @@ function(fetch_prebuilt_tiledb)
if(NOT FETCH_PREBUILT_TILEDB_ARTIFACT_NAME)
detect_artifact_name(FETCH_PREBUILT_TILEDB_ARTIFACT_NAME)
endif()
message(STATUS "Detected TileDB artifact name: ${FETCH_PREBUILT_TILEDB_ARTIFACT_NAME}")

string(STRIP ${HASH_${FETCH_PREBUILT_TILEDB_ARTIFACT_NAME}} HASH_${FETCH_PREBUILT_TILEDB_ARTIFACT_NAME})
FetchContent_Declare(
Expand All @@ -122,4 +127,4 @@ function(fetch_prebuilt_tiledb)
)
FetchContent_MakeAvailable(tiledb)
set(TileDB_DIR ${tiledb_SOURCE_DIR}/lib/cmake/TileDB PARENT_SCOPE)
endfunction()
endfunction()
Loading