Bug fix: Data buffer is not resized for byte objects after completing the buffer and offsets conversion#2150
Merged
kounelisagis merged 4 commits intomainfrom Feb 4, 2025
Conversation
ihnorton
approved these changes
Feb 4, 2025
kounelisagis
deleted the
agis/wrong-calculation-of-the-size-of-the-last-element
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the incorrect calculation of the
data_buffersize when empty bytes are present in the Python list being written to a TileDB Array. The size of thedata_bufferwas incorrectly set to the size of the Python list, which is incorrect because empty bytes are not included in thedata_bufferbeing sent to theQueryExperimental::set_data_bufferC++ API.[sc-62594]