Skip to content

Conversation

@cgiachalis
Copy link
Contributor

@cgiachalis cgiachalis commented Jun 29, 2025

This PR fixes an error message in tiledb_array() to reflect the right source ('selected_points' not 'selected_ranges'). Also, it cleans up various minor typos.

library(tiledb)
df <- data.frame(key=letters[1:5], val=c(1:5))
uri <- tempfile()
fromDataFrame(df, uri, col_index = 1)

# selected_points accepts a vector but we passed a matrix
tiledb_array(uri, selected_points = list(key = cbind(0, 1)))[]
#> Error in validObject(.Object): invalid class "tiledb_array" object: Element '1' of 'selected_ranges' is not a vector.
                                                                                                 ^------------ Should be 'selected_points'

After

#> Error in validObject(.Object) : 
  invalid class “tiledb_array” object: Element '1' of 'selected_points' is not a vector.

@ihnorton ihnorton requested a review from mojaveazure July 21, 2025 18:16
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this! Can you bump the development version in the DESCRIPTION, add a changelog item to NEWS.md before merging?

@cgiachalis
Copy link
Contributor Author

cgiachalis commented Jul 21, 2025

add a changelog item to NEWS.md before merging?

@mojaveazure That's done and ready for merging.

@mojaveazure mojaveazure merged commit 576c045 into TileDB-Inc:main Jul 21, 2025
7 checks passed
@mojaveazure
Copy link
Member

@cgiachalis Great, thank you!

@cgiachalis cgiachalis deleted the cg/fix-error-message branch July 22, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants