Reset timestamp slots for tiledb_array_open_at()
#842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgiachalis
changed the title
tiledb_array_open_at()
Contributor
Author
|
Note that #839 was not addressed in this PR as decisions should be made if you want reset other slots as well e.g., I am planning to open a GitHub Issue for having a |
cgiachalis
force-pushed
the
cg/reset-timestamps-slots
branch
3 times, most recently
from
9e57bf4 to
996cc36
Compare
mojaveazure
approved these changes
Sep 30, 2025
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching! Can you bump the develop version and add a changelog item to NEWS.md before we merge?
cgiachalis
force-pushed
the
cg/reset-timestamps-slots
branch
from
996cc36 to
b20a4d1
Compare
Contributor
Author
|
@mojaveazure We're good to go! |
Member
|
@cgiachalis Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #840 by setting the timestamp slots for
tiledb_array_open_at()to<origin, timestamp>so as the method[can read up to timestamp point of time instead of picking whatever is stored internally.In addition, no unit tests for
tiledb_array_open_at()were found so I added some.closes #840