-
Notifications
You must be signed in to change notification settings - Fork 23
Update CI macos fall back value #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI macos fall back value #845
Conversation
| - {os: macOS-latest} | ||
| - {os: ubuntu-latest} | ||
| - {os: macOS-latest, r: '4.5.1' } | ||
| - {os: ubuntu-latest, r: 'release'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly confusing since RVER has no effect on the Ubuntu builds. For example, someone might try changing it to '4.5.0' or 'devel', and would be surprised that this had no effect. I assume you did this in order to inject the R version in to the name below. I'm not strongly opposed to this strategy, but I wonder if there is an alternative mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you did this in order to inject the R version in to the name below.
Exactly.
|
The alternative would be to modify |
mojaveazure
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching @cgiachalis!
I would say the best alternative mechanism would be to replace r-ci.sh with r-lib/actions as we did in single-cell-data/TileDB-SOMA#4156 and for pkgdown deployments here in #802; these actions are tested and widely-used across the R community, and would allow us to use the more standard names of "release" or "devel" when specifying R versions to test on. This is not a priority for us at the moment, but will likely be where the CI for TileDB-R evolves to
|
Thanks @mojaveazure! |
Running on initial failures in #844, I discovered that macos ci uses an outdated R version: v4.4.1 vs current v4.5.1.
That's because the macos CI uses an environment variable
RVERto select the R version with fallback value "4.4.1". This pull request updates the fallback value to "4.5.1" and ensures that the specific job is not failing fast. Also, I tweaked theincludefield so you can transparently pass the R version for macos to environment variableRVER.At a later point, you could automate the current release of macos installer via R-Hub endpoint:
cc @ihnorton , @mojaveazure