Avoid temporary tiledb_array_t* handle allocations in C API implementations. (#5248)

[SC-53176](https://app.shortcut.com/tiledb-inc/story/53176/remove-unnecessarily-temporary-array-handle-allocations)

This PR replaces internal allocations of temporary `tiledb_array_t*`
handles in the C API implementations, with
`shared_ptr<tiledb::sm::Array>`. This simplifies error handling and
memory management.

---
TYPE: NO_HISTORY

Author: teo-tsirpanis

tiledb/sm/c_api/tiledb.cc

@@ -1437,35 +1437,16 @@ int32_t tiledb_array_get_open_timestamp_end(
 
 int32_t tiledb_array_delete(tiledb_ctx_t* ctx, const char* uri) {
   // Allocate an array object
-  tiledb_array_t* array = new (std::nothrow) tiledb_array_t;
-  try {
-    array->array_ = make_shared<tiledb::sm::Array>(
-        HERE(), ctx->resources(), tiledb::sm::URI(uri));
-  } catch (std::bad_alloc&) {
-    auto st = Status_Error(
-        "Failed to create TileDB array object; Memory allocation error");
-    delete array;
-    array = nullptr;
-    LOG_STATUS_NO_RETURN_VALUE(st);
-    save_error(ctx, st);
-    return TILEDB_OOM;
-  }
-
+  auto array = make_shared<tiledb::sm::Array>(
+      HERE(), ctx->resources(), tiledb::sm::URI(uri));
   // Open the array for exclusive modification
-  throw_if_not_ok(array->array_->open(
+  throw_if_not_ok(array->open(
       tiledb::sm::QueryType::MODIFY_EXCLUSIVE,
       tiledb::sm::EncryptionType::NO_ENCRYPTION,
       nullptr,
       0));
 
-  try {
-    array->array_->delete_array(tiledb::sm::URI(uri));
-  } catch (std::exception& e) {
-    auto st = Status_ArrayError(e.what());
-    LOG_STATUS_NO_RETURN_VALUE(st);
-    save_error(ctx, st);
-    return TILEDB_ERR;
-  }
+  array->delete_array(tiledb::sm::URI(uri));
 
   return TILEDB_OK;
 }
@@ -1477,46 +1458,33 @@ capi_return_t tiledb_array_delete_fragments_v2(
     uint64_t timestamp_end) {
   auto uri = tiledb::sm::URI(uri_str);
   if (uri.is_invalid()) {
-    throw api::CAPIStatusException(
-        "Failed to delete fragments; Invalid input uri");
+    throw CAPIException("Failed to delete fragments; Invalid input uri");
   }
 
   // Allocate an array object
-  tiledb_array_t* array = new (std::nothrow) tiledb_array_t;
-  try {
-    array->array_ =
-        make_shared<tiledb::sm::Array>(HERE(), ctx->resources(), uri);
-  } catch (...) {
-    delete array;
-    array = nullptr;
-    throw api::CAPIStatusException("Failed to create array");
-  }
+  auto array = make_shared<tiledb::sm::Array>(HERE(), ctx->resources(), uri);
 
   // Set array open timestamps
-  array->array_->set_timestamp_start(timestamp_start);
-  array->array_->set_timestamp_end(timestamp_end);
+  array->set_timestamp_start(timestamp_start);
+  array->set_timestamp_end(timestamp_end);
 
   // Open the array for exclusive modification
-  throw_if_not_ok(array->array_->open(
+  throw_if_not_ok(array->open(
       static_cast<tiledb::sm::QueryType>(TILEDB_MODIFY_EXCLUSIVE),
       static_cast<tiledb::sm::EncryptionType>(TILEDB_NO_ENCRYPTION),
       nullptr,
       0));
 
   // Delete fragments
   try {
-    array->array_->delete_fragments(uri, timestamp_start, timestamp_end);
+    array->delete_fragments(uri, timestamp_start, timestamp_end);
   } catch (...) {
-    throw_if_not_ok(array->array_->close());
-    delete array;
-    array = nullptr;
-    throw api::CAPIStatusException("Failed to delete fragments");
+    throw_if_not_ok(array->close());
+    throw CAPIException("Failed to delete fragments");
   }
 
   // Close and delete the array
-  throw_if_not_ok(array->array_->close());
-  delete array;
-  array = nullptr;
+  throw_if_not_ok(array->close());
 
   return TILEDB_OK;
 }
@@ -1528,18 +1496,17 @@ capi_return_t tiledb_array_delete_fragments_list(
     const size_t num_fragments) {
   auto uri = tiledb::sm::URI(uri_str);
   if (uri.is_invalid()) {
-    throw api::CAPIStatusException(
-        "Failed to delete_fragments_list; Invalid input uri");
+    throw CAPIException("Failed to delete_fragments_list; Invalid input uri");
   }
 
   if (num_fragments < 1) {
-    throw api::CAPIStatusException(
+    throw CAPIException(
         "Failed to delete_fragments_list; Invalid input number of fragments");
   }
 
   for (size_t i = 0; i < num_fragments; i++) {
     if (tiledb::sm::URI(fragment_uris[i]).is_invalid()) {
-      throw api::CAPIStatusException(
+      throw CAPIException(
           "Failed to delete_fragments_list; Invalid input fragment uri");
     }
   }
@@ -1552,37 +1519,25 @@ capi_return_t tiledb_array_delete_fragments_list(
   }
 
   // Allocate an array object
-  tiledb_array_t* array = new (std::nothrow) tiledb_array_t;
-  try {
-    array->array_ =
-        make_shared<tiledb::sm::Array>(HERE(), ctx->resources(), uri);
-  } catch (...) {
-    delete array;
-    array = nullptr;
-    throw api::CAPIStatusException("Failed to create array");
-  }
+  auto array = make_shared<tiledb::sm::Array>(HERE(), ctx->resources(), uri);
 
   // Open the array for exclusive modification
-  throw_if_not_ok(array->array_->open(
-      static_cast<tiledb::sm::QueryType>(TILEDB_MODIFY_EXCLUSIVE),
-      static_cast<tiledb::sm::EncryptionType>(TILEDB_NO_ENCRYPTION),
+  throw_if_not_ok(array->open(
+      tiledb::sm::QueryType::MODIFY_EXCLUSIVE,
+      tiledb::sm::EncryptionType::NO_ENCRYPTION,
       nullptr,
       0));
 
   // Delete fragments list
   try {
-    array->array_->delete_fragments_list(uris);
+    array->delete_fragments_list(uris);
   } catch (...) {
-    throw_if_not_ok(array->array_->close());
-    delete array;
-    array = nullptr;
-    throw api::CAPIStatusException("Failed to delete fragments_list");
+    throw_if_not_ok(array->close());
+    throw CAPIException("Failed to delete fragments_list");
   }
 
   // Close the array
-  throw_if_not_ok(array->array_->close());
-  delete array;
-  array = nullptr;
+  throw_if_not_ok(array->close());
 
   return TILEDB_OK;
 }