Skip to content

Commit ea0a866

Browse files
authored
Enable array open v2 and query v3 by default. (#5207)
[[sc-47320](https://app.shortcut.com/tiledb-inc/story/47320)] This PR just changes the two configuration variables that toggle "Array open v2" and "Query v3" features to ON by default. --- TYPE: FEATURE DESC: Enable array open v2 and query v3 by default.
1 parent 41eb1cc commit ea0a866

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

test/src/unit-capi-config.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,8 @@ void check_save_to_file() {
239239
ss << "rest.retry_initial_delay_ms 500\n";
240240
ss << "rest.server_address https://api.tiledb.com\n";
241241
ss << "rest.server_serialization_format CAPNP\n";
242-
ss << "rest.use_refactored_array_open false\n";
243-
ss << "rest.use_refactored_array_open_and_query_submit false\n";
242+
ss << "rest.use_refactored_array_open true\n";
243+
ss << "rest.use_refactored_array_open_and_query_submit true\n";
244244
ss << "sm.allow_separate_attribute_writes false\n";
245245
ss << "sm.allow_updates_experimental false\n";
246246
ss << "sm.check_coord_dups true\n";
@@ -579,13 +579,13 @@ TEST_CASE("C API: Test config iter", "[capi][config]") {
579579
CHECK(rc == TILEDB_OK);
580580
CHECK(error == nullptr);
581581
rc = tiledb_config_set(
582-
config, "rest.use_refactored_array_open", "true", &error);
582+
config, "rest.use_refactored_array_open", "false", &error);
583583
CHECK(rc == TILEDB_OK);
584584
CHECK(error == nullptr);
585585
rc = tiledb_config_set(
586586
config,
587587
"rest.use_refactored_array_open_and_query_submit",
588-
"true",
588+
"false",
589589
&error);
590590
CHECK(rc == TILEDB_OK);
591591
CHECK(error == nullptr);
@@ -613,8 +613,8 @@ TEST_CASE("C API: Test config iter", "[capi][config]") {
613613
all_param_values["rest.load_metadata_on_array_open"] = "false";
614614
all_param_values["rest.load_non_empty_domain_on_array_open"] = "false";
615615
all_param_values["rest.load_enumerations_on_array_open"] = "false";
616-
all_param_values["rest.use_refactored_array_open"] = "true";
617-
all_param_values["rest.use_refactored_array_open_and_query_submit"] = "true";
616+
all_param_values["rest.use_refactored_array_open"] = "false";
617+
all_param_values["rest.use_refactored_array_open_and_query_submit"] = "false";
618618
all_param_values["rest.payer_namespace"] = "";
619619
all_param_values["sm.allow_separate_attribute_writes"] = "false";
620620
all_param_values["sm.allow_updates_experimental"] = "false";

tiledb/api/c_api/config/config_api_external.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -741,13 +741,13 @@ TILEDB_EXPORT void tiledb_config_free(tiledb_config_t** config) TILEDB_NOEXCEPT;
741741
* with the open array <br>
742742
* **Default**: true
743743
* - `rest.use_refactored_array_open` <br>
744-
* If true, the new, experimental REST routes and APIs for opening an array
744+
* If true, the new REST routes and APIs for opening an array
745745
* will be used <br>
746-
* **Default**: false
746+
* **Default**: true
747747
* - `rest.use_refactored_array_open_and_query_submit` <br>
748-
* If true, the new, experimental REST routes and APIs for opening an array
749-
* and submitting a query will be used <br>
750-
* **Default**: false
748+
* If true, the new REST routes and APIs for opening an array and submitting
749+
* a query will be used <br>
750+
* **Default**: true
751751
* - `rest.curl.buffer_size` <br>
752752
* Set curl buffer size for REST requests <br>
753753
* **Default**: 524288 (512KB)

tiledb/sm/config/config.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ const std::string Config::REST_CURL_VERBOSE = "false";
9494
const std::string Config::REST_LOAD_ENUMERATIONS_ON_ARRAY_OPEN = "true";
9595
const std::string Config::REST_LOAD_METADATA_ON_ARRAY_OPEN = "true";
9696
const std::string Config::REST_LOAD_NON_EMPTY_DOMAIN_ON_ARRAY_OPEN = "true";
97-
const std::string Config::REST_USE_REFACTORED_ARRAY_OPEN = "false";
98-
const std::string Config::REST_USE_REFACTORED_QUERY_SUBMIT = "false";
97+
const std::string Config::REST_USE_REFACTORED_ARRAY_OPEN = "true";
98+
const std::string Config::REST_USE_REFACTORED_QUERY_SUBMIT = "true";
9999
const std::string Config::REST_PAYER_NAMESPACE = "";
100100
const std::string Config::SM_ALLOW_SEPARATE_ATTRIBUTE_WRITES = "false";
101101
const std::string Config::SM_ALLOW_UPDATES_EXPERIMENTAL = "false";

tiledb/sm/cpp_api/config.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -916,13 +916,13 @@ class Config {
916916
* together with the open array <br>
917917
* **Default**: true
918918
* - `rest.use_refactored_array_open` <br>
919-
* If true, the new, experimental REST routes and APIs for opening an array
920-
* will be used <br>
921-
* **Default**: false
919+
* If true, the new REST routes and APIs for opening an array will be used
920+
* <br>
921+
* **Default**: true
922922
* - `rest.use_refactored_array_open_and_query_submit` <br>
923-
* If true, the new, experimental REST routes and APIs for opening an array
924-
* and submitting a query will be used <br>
925-
* **Default**: false
923+
* If true, the new REST routes and APIs for opening an array and
924+
* submitting a query will be used <br>
925+
* **Default**: true
926926
* - `rest.curl.buffer_size` <br>
927927
* Set curl buffer size for REST requests <br>
928928
* **Default**: 524288 (512KB)

0 commit comments

Comments
 (0)