Skip to content

feat: add tiledb_query_add_predicate API to parse a SQL expression string into a QueryCondition #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rroelke wants to merge 56 commits into
base: main
Choose a base branch
from
+4,437 −1,377
Open

feat: add tiledb_query_add_predicate API to parse a SQL expression string into a QueryCondition #5566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
94eeeff
tiledb_query_add_predicate
rroelke Apr 4, 2025
ad3f43c
Remove assert post rebase
rroelke Jun 30, 2025
c10ef48
Fill in WHERE a IS NOT NULL example
rroelke Jun 30, 2025
6017582
Fill in other global order unit test examples
rroelke Jun 30, 2025
303e831
unit-query-add-predicate.cc tests for other readers
rroelke Jun 30, 2025
7aaedd5
Move datafusion session to query instead of ContextResources
rroelke Jul 1, 2025
3668cda
Tweak example comment
rroelke Jul 1, 2025
4e2eebf
Enumeration::create const std::vector
rroelke Jul 1, 2025
bd16e7b
Tweak example
rroelke Jul 1, 2025
40cb894
cpp example
rroelke Jul 1, 2025
2139297
clippy
rroelke Jul 1, 2025
f10d157
Add test on evolved schema
rroelke Jul 1, 2025
2b72ba4
Change test names
rroelke Jul 1, 2025
1d962ec
Fix non-rust build
rroelke Jul 1, 2025
b0d36d3
Fix osx build errors
rroelke Jul 1, 2025
f246bd7
Fix C API example print_elem buffer
rroelke Jul 1, 2025
744728d
Comment new/updated test support functions
rroelke Jul 1, 2025
bead919
Remove unnecessary ExternType impl
rroelke Jul 1, 2025
02fb0ca
Self-review code comments
rroelke Jul 1, 2025
ec829e0
Attempt to fix query_add_predicate error
rroelke Jul 1, 2025
f2ddb4b
Undo clang-format-17 string splits
rroelke Jul 2, 2025
176a021
Change C++ API to use std::string
rroelke Jul 2, 2025
d1c7680
Remove logger_->status
rroelke Jul 2, 2025
653c890
SQL dialect in API comments
rroelke Jul 2, 2025
a00301c
Query add predicate to in progress query
rroelke Jul 2, 2025
be32216
Fix bizarre -Warray-bounds error for b_data_offsets
rroelke Jul 2, 2025
763a3e2
Query add predicate with query condition
rroelke Jul 2, 2025
1ab697f
Add tests demonstrating field escaping
rroelke Jul 2, 2025
2c05e33
Add some FFI for sm Buffer
rroelke Jul 3, 2025
666e138
FFI use_enumeration
rroelke Jul 3, 2025
069162b
Bindings for accessing enumeration contents and locating them in a sc…
rroelke Jul 3, 2025
9758e7f
ArrowSchema => ArrowArraySchema, contains dyn ArrowArray for enumerat…
rroelke Jul 3, 2025
b41d1aa
Move definitions to .cc file to avoid multiple definition error
rroelke Jul 3, 2025
d78e434
Add WhichSchema to distinguish schema for view vs. storage, passes un…
rroelke Jul 3, 2025
860d3d5
Fix wrong write size in unit_query_condition.cc
rroelke Jul 3, 2025
9d8e4ff
Fix UTF-8, unit_query_condition passes
rroelke Jul 3, 2025
d6889bd
Stopgap for enumerations in WhichSchema::View
rroelke Jul 3, 2025
d5caf2c
clippy
rroelke Jul 3, 2025
314b169
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke Jul 21, 2025
9046ef1
RestClientFactory can construct in place
rroelke Jul 21, 2025
33c8a72
Handle TILEDB_RUST=OFF in unit-query-add-predicate.cc
rroelke Jul 21, 2025
a3e6617
HeapMemoryLinter ignores oxidize dir
rroelke Jul 21, 2025
e18ccd7
Fix empty dimension tuple
rroelke Jul 21, 2025
f1d7eb5
make format
rroelke Jul 21, 2025
27a1be3
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke Sep 15, 2025
572ba80
Remove non-experimental version of add_predicate
rroelke Oct 22, 2025
0edb237
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke Oct 22, 2025
77c0f85
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke Nov 12, 2025
1823e8a
Fix error message grammar
rroelke Nov 12, 2025
c242c16
Split no predicate and WHERE TRUE in examples
rroelke Nov 12, 2025
d8eb419
cargo update and remove cxxbridge version pin
rroelke Nov 12, 2025
66ff1fc
Single QueryPredicates FFI boundary compiles, not tested
rroelke Nov 13, 2025
5d2521e
Single QueryPredicates FFI boundary passes existing tests
rroelke Nov 14, 2025
48195cf
unit_query_condition and API test both pass
rroelke Nov 17, 2025
6f7d080
self review
rroelke Nov 17, 2025
199ea2f
clippy
rroelke Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cmake/oxidize.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,9 @@ if (TILEDB_RUST)
set(CARGO_INSTALL_ROOT ${CMAKE_BINARY_DIR}/cargo/install)
set(CARGO_INSTALL_BIN ${CARGO_INSTALL_ROOT}/bin)

# pin version of cxxbridge due to https://github.com/dtolnay/cxx/issues/1436 build errors on MacOS
set(CXXBRIDGE_VERSION 1.0.138)

execute_process(
COMMAND
${CARGO} install cxxbridge-cmd --version ${CXXBRIDGE_VERSION} --root ${CARGO_INSTALL_ROOT}
${CARGO} install cxxbridge-cmd --root ${CARGO_INSTALL_ROOT}
)
execute_process(
COMMAND
Expand Down
Loading
Loading