-
Notifications
You must be signed in to change notification settings - Fork 202
chore: Add global order min/max per tile to the fragment metadata #5646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rroelke
wants to merge
59
commits into
main
Choose a base branch
from
rr/core-321-fragment-metdata-global-order-bounds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
a187efb
Domain option version of get_dimension_index
rroelke cb22d35
Dimension::cell_size
rroelke 760f643
Add tile global/order min/max, bump format version, not tested
rroelke fb387bd
Stubs for C API retrieving tile global order bounds
rroelke d3d9936
Fixed-length simple test passes
rroelke 273a0bb
Fix test with serialization on
rroelke 6ad6ac9
Fix set_num_tiles index for bounds buffers
rroelke fa5b8ee
Add tiledb::Array::context
rroelke 01ec15b
Refactor some functions into array_templates.h
rroelke bfbec1f
Refactor Fragment1D, Fragment2D into common base class
rroelke a018738
Fragment metadata global order bounds example passes
rroelke 7a1e6e6
Add unordered 1D test
rroelke b639572
Rapidcheck runs, prints minimum
rroelke f642e6e
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke 9c900b3
Add RestProfile::file_exists to avoid throwing exception for failing …
rroelke 99e04db
Fix offset by tile_index_base_
rroelke 83e2b36
Rapidcheck passes for fixed 1D no dups
rroelke 4947b3a
Turn on dups
rroelke f9b93fb
Fix Fragment2d::d2
rroelke b997f22
Test Fragment metadata global order bounds: 2D fixed unordered section
rroelke 52672dc
Test Fragment metadata global order bounds: 2D fixed global order sec…
rroelke 72cdd82
Add 1D var test with trivial input
rroelke 23e9420
Trivial 1D var test passes
rroelke 49cd23e
Minimum write GENERATE
rroelke 5dbee50
Fix global_cell_cmp_std_tuple for variable-length dimension
rroelke 23c397f
Fix set_tile_global_order_bounds_var indexing
rroelke 0e25643
Nontrival 1D var test
rroelke b7ab7f1
Fragment::extend
rroelke a0dedb9
Fix prepare_bound_buffers for empty qb
rroelke eed749a
Fragment metadata global order bounds: 1D fixed consolidation non-ove…
rroelke 38b981b
Add interleaving 1d fixed consolidation test
rroelke f1f64a5
Additional consolidation tests, 1d fixed rapidcheck and 1d var
rroelke d7cc660
Domain::cell_order_cmp overload consistency
rroelke 8805da0
Add 1D var rapidcheck test, does not pass
rroelke 9dad9a6
Fix set_tile_global_order_bounds_var tile
rroelke 11d2601
Shrinking section
rroelke 654c679
rapidcheck show functions
rroelke af2dc5a
1D var consolidation rapidcheck
rroelke bb4ebaa
make_fragment_3d
rroelke 6cb0b1d
3D vcf rapidcheck
rroelke 722f3e0
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke 44469f8
Add C++ API and use it in tests
rroelke d176eb6
Add 3D vcf consolidation rapidcheck test
rroelke e76b0ce
Update format spec
rroelke 029592c
Only write global order min/maxes for sparse array
rroelke 36d624c
Allow dimension_sizes arg to be nullptr
rroelke 369e02a
Recapture output for 'dump with string dimension' test
rroelke 045beb4
Fix interleaving triples output
rroelke 0e4d960
Fix cpp context lifetime issue
rroelke 4d08b0c
constexpr UntypedDatumView methods/constructors
rroelke 5886af9
Fix cppapi impl dimension_sizes
rroelke 804051e
std::min explicit template to make mac compiler happy
rroelke 3c316af
Fix format spec typos and version number
rroelke 0434459
Separate method for new versioning
rroelke 47df461
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke 12fec8b
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke f187ce3
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke 5c0b0af
Merge remote-tracking branch 'origin/main' into rr/core-321-fragment-…
rroelke 677fa62
Restore Dimension<STRING_ASCII> specialization
rroelke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.