refactor(ts-sdk): remove misleading isBrowser() - SDK requires Node.js only

- Remove isBrowser() function that implied browser compatibility
- Simplify getEnv() and isEnvSet() to directly use process.env
- SDK fundamentally cannot run in browsers due to Node.js module imports
- Add tests to verify isBrowser is not exported

Author: Timandes

rock/ts-sdk/src/index.ts

@@ -34,7 +34,7 @@ export { RunMode, RunModeType, PID_PREFIX, PID_SUFFIX } from './common/constants
 export { HttpUtils } from './utils/http.js';
 export { retryAsync, sleep, withRetry } from './utils/retry.js';
 export { deprecated, deprecatedClass } from './utils/deprecated.js';
-export { isNode, isBrowser, getEnv, getRequiredEnv, isEnvSet } from './utils/system.js';
+export { isNode, getEnv, getRequiredEnv, isEnvSet } from './utils/system.js';
 
 // EnvHub
 export * from './envhub/index.js';

rock/ts-sdk/src/utils/system.test.ts

@@ -0,0 +1,121 @@
+/**
+ * Tests for system utilities
+ * 
+ * These tests verify that the SDK explicitly requires Node.js environment
+ * and does not include misleading browser compatibility checks.
+ */
+
+import { isNode, getEnv, getRequiredEnv, isEnvSet } from './system.js';
+
+describe('system utilities', () => {
+  describe('isNode', () => {
+    test('returns true in Node.js environment', () => {
+      expect(isNode()).toBe(true);
+    });
+  });
+
+  describe('getEnv', () => {
+    const originalEnv = process.env;
+
+    beforeEach(() => {
+      // Reset process.env for each test
+      process.env = { ...originalEnv };
+    });
+
+    afterAll(() => {
+      process.env = originalEnv;
+    });
+
+    test('returns environment variable value when set', () => {
+      process.env.TEST_VAR = 'test-value';
+      expect(getEnv('TEST_VAR')).toBe('test-value');
+    });
+
+    test('returns undefined when variable not set and no default', () => {
+      delete process.env.NONEXISTENT_VAR;
+      expect(getEnv('NONEXISTENT_VAR')).toBeUndefined();
+    });
+
+    test('returns default value when variable not set', () => {
+      delete process.env.NONEXISTENT_VAR;
+      expect(getEnv('NONEXISTENT_VAR', 'default-value')).toBe('default-value');
+    });
+
+    test('returns actual value even when default is provided', () => {
+      process.env.TEST_VAR = 'actual-value';
+      expect(getEnv('TEST_VAR', 'default-value')).toBe('actual-value');
+    });
+  });
+
+  describe('getRequiredEnv', () => {
+    const originalEnv = process.env;
+
+    beforeEach(() => {
+      process.env = { ...originalEnv };
+    });
+
+    afterAll(() => {
+      process.env = originalEnv;
+    });
+
+    test('returns value when environment variable is set', () => {
+      process.env.REQUIRED_VAR = 'required-value';
+      expect(getRequiredEnv('REQUIRED_VAR')).toBe('required-value');
+    });
+
+    test('throws error when environment variable is not set', () => {
+      delete process.env.NONEXISTENT_REQUIRED_VAR;
+      expect(() => getRequiredEnv('NONEXISTENT_REQUIRED_VAR')).toThrow(
+        'Required environment variable NONEXISTENT_REQUIRED_VAR is not set'
+      );
+    });
+  });
+
+  describe('isEnvSet', () => {
+    const originalEnv = process.env;
+
+    beforeEach(() => {
+      process.env = { ...originalEnv };
+    });
+
+    afterAll(() => {
+      process.env = originalEnv;
+    });
+
+    test('returns true when environment variable is set', () => {
+      process.env.SET_VAR = 'value';
+      expect(isEnvSet('SET_VAR')).toBe(true);
+    });
+
+    test('returns true when environment variable is set to empty string', () => {
+      process.env.EMPTY_VAR = '';
+      expect(isEnvSet('EMPTY_VAR')).toBe(true);
+    });
+
+    test('returns false when environment variable is not set', () => {
+      delete process.env.UNSET_VAR;
+      expect(isEnvSet('UNSET_VAR')).toBe(false);
+    });
+  });
+});
+
+/**
+ * Test that isBrowser is NOT exported from the main index.
+ * This SDK requires Node.js and should not have misleading browser checks.
+ */
+describe('Node.js only requirement', () => {
+  test('isBrowser should not be exported from main index', async () => {
+    const mainModule = await import('../index.js');
+    
+    // isBrowser should NOT be exported - this is intentional
+    expect('isBrowser' in mainModule).toBe(false);
+  });
+
+  test('isBrowser should not be exported from system.js', async () => {
+    // Re-import to check the module's exports
+    const systemModule = await import('./system.js');
+    
+    // isBrowser should NOT be exported
+    expect('isBrowser' in systemModule).toBe(false);
+  });
+});

rock/ts-sdk/src/utils/system.ts

@@ -1,5 +1,8 @@
 /**
  * System utilities
+ * 
+ * Note: This SDK requires Node.js environment (v20.8.0+).
+ * It cannot run in browsers due to dependencies on Node.js modules.
  */
 
 /**
@@ -13,23 +16,12 @@ export function isNode(): boolean {
   );
 }
 
-/**
- * Check if running in browser environment
- */
-export function isBrowser(): boolean {
-  return typeof globalThis !== 'undefined' && 
-    'window' in globalThis && 
-    typeof (globalThis as Record<string, unknown>).window !== 'undefined';
-}
-
 /**
  * Get environment variable
+ * Directly accesses process.env since this SDK requires Node.js
  */
 export function getEnv(key: string, defaultValue?: string): string | undefined {
-  if (isNode()) {
-    return process.env[key] ?? defaultValue;
-  }
-  return defaultValue;
+  return process.env[key] ?? defaultValue;
 }
 
 /**
@@ -45,10 +37,8 @@ export function getRequiredEnv(key: string): string {
 
 /**
  * Check if environment variable is set
+ * Directly checks process.env since this SDK requires Node.js
  */
 export function isEnvSet(key: string): boolean {
-  if (isNode()) {
-    return key in process.env;
-  }
-  return false;
+  return key in process.env;
 }