Skip to content

chore: remove the use of IntValueRange #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
+10 −14
Merged

chore: remove the use of IntValueRange #942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions java/project-job-scheduling/src/main/java/org/acme/projectjobschedule/domain/Allocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,22 @@
package org.acme.projectjobschedule.domain;

import java.util.Arrays;
import java.util.List;
import java.util.Objects;

import ai.timefold.solver.core.api.domain.entity.PlanningEntity;
import ai.timefold.solver.core.api.domain.entity.PlanningPin;
import ai.timefold.solver.core.api.domain.lookup.PlanningId;
import ai.timefold.solver.core.api.domain.valuerange.CountableValueRange;
import ai.timefold.solver.core.api.domain.valuerange.ValueRangeFactory;
import ai.timefold.solver.core.api.domain.valuerange.ValueRangeProvider;
import ai.timefold.solver.core.api.domain.variable.PlanningVariable;
import ai.timefold.solver.core.api.domain.variable.ShadowSources;
import ai.timefold.solver.core.api.domain.variable.ShadowVariable;
import ai.timefold.solver.core.api.domain.variable.ShadowVariablesInconsistent;

import org.acme.projectjobschedule.domain.solver.DelayStrengthComparator;

import com.fasterxml.jackson.annotation.JsonIdentityInfo;
import com.fasterxml.jackson.annotation.JsonIdentityReference;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.ObjectIdGenerators;
import org.acme.projectjobschedule.domain.solver.DelayStrengthComparator;

import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import java.util.stream.IntStream;

@PlanningEntity
@JsonIdentityInfo(scope = Allocation.class, generator = ObjectIdGenerators.PropertyGenerator.class, property = "id")
Expand Down Expand Up @@ -87,8 +83,8 @@ public List<ExecutionMode> getExecutionModeRange() {

@ValueRangeProvider
@JsonIgnore
public CountableValueRange<Integer> getDelayRange() {
return ValueRangeFactory.createIntValueRange(0, 500);
public List<Integer> getDelayRange() {
return IntStream.range(0, 500).boxed().toList();
}

// ************************************************************************
Expand All @@ -109,7 +105,7 @@ public boolean isPinned() {

/**
* Sources and sinks will always be pinned.
*
*
* @param pinned Ignored unless {@link #getJob()}'s {@link JobType} is {@link JobType#STANDARD}.
*/
public void setPinned(boolean pinned) {
Expand All @@ -131,7 +127,7 @@ public Job getJob() {

/**
* Resets {@link #isPinned()}.
*
*
* @param job never null
*/
public void setJob(Job job) {
Expand Down
Loading