Skip to content

Conversation

@triceo
Copy link
Collaborator

@triceo triceo commented Jan 16, 2026

Replaces #972.

Copilot AI review requested due to automatic review settings January 16, 2026 09:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors constraint providers to use new specialized joiner methods (containing, containedIn, intersecting) instead of generic filtering joiners, replacing PR #972. The changes improve code readability and leverage Timefold's optimized joiner implementations.

Changes:

  • Replaced filtering with Joiners.intersecting for set intersection checks
  • Replaced filtering with Joiners.containing and containedIn for containment checks
  • Removed obsolete helper methods from Talk class that are no longer needed
  • Reorganized imports for better structure

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
java/maintenance-scheduling/src/main/java/org/acme/maintenancescheduling/solver/MaintenanceScheduleConstraintProvider.java Replaced filtering with Joiners.intersecting for tag conflict detection; reorganized imports
java/conference-scheduling/src/main/java/org/acme/conferencescheduling/solver/ConferenceSchedulingConstraintProvider.java Replaced multiple filtering joiners with specialized joiners (containing, containedIn, intersecting) across 13 constraints; reorganized imports
java/conference-scheduling/src/main/java/org/acme/conferencescheduling/domain/Talk.java Removed helper methods hasSpeaker, hasMutualSpeaker, and overlapsTime that are no longer needed after joiner refactoring; reorganized imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@triceo triceo requested a review from TomCools January 16, 2026 11:05
Copy link
Collaborator

@TomCools TomCools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants