-
Notifications
You must be signed in to change notification settings - Fork 175
feat: Support deep_planning_clone class decorator #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bef4b6a to
e13b83c
Compare
|
Thank you for your contribution, @luxaritas! We are a bit short-handed at the moment, with many people already taking their year-end holidays. I'm going to leave this one open until my colleague, who owns the Python part of the codebase, comes back in early January and does a code review. Please be patient - we have every intention to merge this PR. |
|
On a general note though:
This issue also happens on Python 3.11 and 3.12. (We do not yet support 3.13.)
|
|
Completely understand folks being out - I have my own local adjustments for my PRs so no big deal for me anyways! I caught the CI failure after I'd already stepped away - copy-paste error. Will look into tests as well. |
Christopher-Chianelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Docstring for attribute DeepPlanningClone should still mention planning_entity/planning_solution (those attributes are automatically planning cloned). Also need to test if a new instance is created in the test.
The actual implementation looks correct.
|
Hello @luxaritas - 2025 is here, we are back, and your PR's been reviewed. |
55a3e97 to
c3685aa
Compare
84e4bc7 to
264591c
Compare
264591c to
49d8770
Compare
|
Resolved and rebased! |
The requested changes were made.
|
|
Thank you, @luxaritas! Scheduled for a next-week release. |



This brings parity with the Java version (I also found that DeepPlanningClone did not work on a planning solution ProblemFactCollectionProperty, whereas marking the entire class to deep clone does)