feat: add ability to run a move during testing #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceo
commented
Jan 20, 2026
| * This class is an internal detail and must not be exposed to the user. | ||
| */ | ||
| @NullMarked | ||
| static final class DummyConstraintProvider implements ConstraintProvider { |
Collaborator
Author
There was a problem hiding this comment.
This forces some changes to Quarkus/Spring.
I made these manually, as I didn't trust the agent to figure it out without all the speccing and planning prerequisites.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new MoveRunner API for testing move implementations during development. The feature was implemented using AI assistance (Claude Sonnet 4.5) based on specifications created through human-AI collaboration.
Changes:
- Added new testing API (
MoveRunnerandMoveRunContext) for executing moves with automatic undo support - Updated Spring Boot and Quarkus auto-configuration to filter out internal test classes
- Enhanced configuration utilities to support non-public inner static classes
- Added comprehensive test coverage using the new API with builtin moves
- Updated documentation with usage examples and best practices
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| MoveRunner.java | New API entry point providing fluent interface for move execution with resource management |
| MoveRunContext.java | New execution context for permanent and temporary move execution |
| InnerScoreDirector.java | Added executeTemporarily variant accepting consumer callback |
| AbstractScoreDirector.java | Implemented new executeTemporarily method delegating to move director |
| ConfigUtils.java | Enhanced to support non-public inner static class instantiation |
| TimefoldSolverAutoConfiguration.java | Added UNIQUENESS_PREDICATE to filter internal classes and abstract types |
| IncludeAbstractClassesEntityScanner.java | Updated to use shared UNIQUENESS_PREDICATE |
| TimefoldProcessor.java | Added UNIQUENESS_PREDICATE and renamed logger constant |
| Moves.java | Updated swap methods with proper type parameterization |
| neighborhoods.adoc | Added comprehensive MoveRunner API documentation |
| *MoveTest.java (6 files) | New test classes demonstrating MoveRunner usage with builtin moves |
| MoveRunnerTest.java | Unit tests for MoveRunner API |
| Specification files | Complete feature specification, design, and implementation plan |
...uarkus/deployment/src/main/java/ai/timefold/solver/quarkus/deployment/TimefoldProcessor.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was written entirely using SpecKit. Human+AI collaboration went into the specification; the code produced was 99 % done by Claude Sonnet 4.5.
Important pieces:
spec.mdcontains the specification of the featureplan.md(and accompanying data model + API) contains the AI's implementation planconstitution.md- I drafted some amendments as I was watching AI produce code that didn't look like "our" code.I'm asking both @Christopher-Chianelli and @zepfred for a very careful code review. I have two reasons for that:
I do not recommend reviewing commit-by-commit. Review the final product, if you wish to keep your sanity.