Skip to content

Consolidate output diffs before producing tuples #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Consolidate output diffs before producing tuples #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/operators/arrange/arrangement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ where
I::Item: Data,
L: FnMut(Tr::Key<'_>, Tr::Val<'_>) -> I+'static,
{
let mut buffer = Vec::new();
stream.unary(Pipeline, "AsCollection", move |_,_| move |input, output| {
input.for_each(|time, data| {
let mut session = output.session(&time);
Expand All @@ -213,11 +214,19 @@ where
let mut cursor = batch.cursor();
while let Some(key) = cursor.get_key(batch) {
while let Some(val) = cursor.get_val(batch) {
for datum in logic(key, val) {
let mut iter = logic(key, val).into_iter().peekable();
if iter.peek().is_some() {
cursor.map_times(batch, |time, diff| {
session.give((datum.clone(), time.clone(), diff.clone()));
buffer.push((time.clone(), diff.clone()));
});
crate::consolidation::consolidate(&mut buffer);
}
for datum in iter {
for (time, diff) in buffer.iter() {
session.give((datum.clone(), time.clone(), diff.clone()));
}
}
buffer.clear();
cursor.step_val(batch);
}
cursor.step_key(batch);
Expand Down