Remove flatcontainer, absorb TimelyStack #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust to changes in TimelyDataflow/timely-dataflow#647 which removes flatcontainer and columnation as Timely doesn't have any opinion around the types and defers to downstream crates instead. Ideally, we'd move the TimelyStack to an example, but that would be a bigger change, so I'm holding off for the moment. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
remove_flat_absorb_columnation
branch
from
249089f to
26905ff
Compare
Member
|
This feels good, thank you! It seems to bring the collection of opinions on containers together, e.g. around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust to changes in TimelyDataflow/timely-dataflow#647 which removes
flatcontainer and columnation as Timely doesn't have any opinion around
the types and defers to downstream crates instead.
Ideally, we'd move the TimelyStack to an example, but that would be a
bigger change, so I'm holding off for the moment.
Signed-off-by: Moritz Hoffmann [email protected]