Remove ReadItem from BatchContainer #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
The BatchIndex trait is similiar to Columnar's Index trait. We implment it for _refernces_ to BatchContainers, so that the reference type is not a GAT but rather a simple associated type. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ReadItem<'a> from BatchContainer, introduce a BatchIndex trait that behaves similarly to columnar's Index trait: It has an associated type (not lifetimed) and implementations use the lifetime of
&'a Selfto express their constraints.The wrinkle it introduces is that the trace reader/cursor/batch traits need to gain functions to work with (G)ATs where the behavior was previously encoded in
IntoOwned. I'd like to remove theIntoOwnedtrait because it makes it hard for other crates to use Differential, but that'd mean we have to add more functions to work with keys and values, too.I started off the wrong branch, so there's a bunch of unrelated changes. Only look at the last commit (3e97287)