Remove use of borrow_as from trace wrappers
#609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Jun 20, 2025
antiguru
approved these changes
Jun 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two trace wrappers relied on
IntoOwned::borrow_asto convert from&TimetoTimeGat<'_>, in order to support closures against their advertised time reference type. This PR changes the advertisement to be&Timeinstead, and the callers can rely onborrow_asthemselves if they have a problem with that.I think the
freeze.rschanges likely have zero impact (and perhaps the file should be deprecated). Thefrontier.rschanges likely affect Materialize, which uses it, but it could/should be a pretty easy fix, if the types aren't already aligned (I half guess that they are already&Timeas the GAT type).