Modernize many where constraints #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
reviewed
Jun 20, 2025
| - windows | ||
| toolchain: | ||
| - stable | ||
| - 1.78 |
Member
Author
There was a problem hiding this comment.
Might also delete windows, but .. really would rather not. :D
Member
Author
|
The windows CI failures seem to be a recognized MSVC regression, no eta listed and it's been a few weeks, so dropping windows from CI for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust
1.87(ed: idk some recent version) stabilized bounds in associated types, which allows "simplification" of a lot of constraints that were expressed as danglingwhereconstraints. Although things get a bit wordier in moments, it clarifies that the associated type we are constraining comes from the trait in question. It may be that some of the changes are aesthetically unappealing, and perhaps we want to pop more things out intowhereblocks, but I do like the association of the bound with the trait containing the associated types.