Avoid allocation in progcaster #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd first clone the changes to be sent downstream before converting them to a vector. This can cause two allocations, one for cloning the change batch, and one for the `to_vec` call (it takes self by reference). This change adjusts it so that we convert the SmallVec into a vector (`into_vec`). Signed-off-by: Moritz Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd first clone the changes to be sent downstream before
converting them to a vector. This can cause two allocations, one for
cloning the change batch, and one for the
to_veccall (it takes self byreference). This change adjusts it so that we convert the SmallVec into a
vector (
into_vec).Signed-off-by: Moritz Hoffmann [email protected]