Log operator summaries using clever approach #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Jan 17, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks great, I left some comments!
| identifier: usize, | ||
| logging: Option<Logger> | ||
| logging: Option<Logger>, | ||
| summary_logging: &mut Option<SummaryLogger<T::Summary>>, |
Member
There was a problem hiding this comment.
Alternatively Option<&mut SummaryLogger<...>>? I can't seem to ever know which one to use where, but here we don't want to change the option... Also, logging mightn't need mutable access iirc
Member
Author
There was a problem hiding this comment.
Will address in a follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at logging operator summaries (the internal matrix of input->output timestamp summaries describing the operator's internal connectivity). I mostly copied existing code, and .. once this is up I'll be able to have a better look and see if it makes any sense. It roughly follows #624 which did something similar for progress and reachability logging, though I may have erred in important ways.