Allow event iterators to surface owned data #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, event iterators were forced to handing out references to data, even if they could return owned data. This is not great because it requires the replay operator to clone the data to send it downstream. With this change, the event iterator can surface either owned or shared data, which allows the `Rc<EventLink>` to surface owned data when it is uniquely owned, and references when it is shared. This avoids cloning data when there is only a single replay operator attached to an event link. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
frankmcsherry
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, event iterators were forced to handing out references to data,
even if they could return owned data. This is not great because it requires
the replay operator to clone the data to send it downstream.
With this change, the event iterator can surface either owned or shared
data, which allows the
Rc<EventLink>to surface owned data when it isuniquely owned, and references when it is shared. This avoids cloning data
when there is only a single replay operator attached to an event link.
Signed-off-by: Moritz Hoffmann [email protected]