Flatten reachability logging, log identifier #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, reachability and progress logging would use their address to identify the place where an event happened. In logging this is not great because every event needs to come with a vector. Instead, use the operator's global identifier, which we can translate back to the address using the operates events. Flattens the reachability logs so they contain no vectors anymore. This comes at the expense of logging the identifier more frequently. I think the change is justifiable as the vector previously had at least the size of three identifiers, plus the memory of the address itself, so only once we log more than at least three events, we use more space than we did before. Signed-off-by: Moritz Hoffmann <[email protected]>
Comment on lines
60
to
68
| /// Adds a child `Operate` to the builder's scope using a supplied index. | ||
| /// | ||
| /// This is used internally when there is a gap between allocate a child identifier and adding the | ||
| /// child, as happens in subgraph creation. | ||
| fn add_operator_with_index(&mut self, operator: Box<dyn Operate<Self::Timestamp>>, index: usize) { | ||
| let global = self.new_identifier(); | ||
| self.add_operator_with_indices(operator, index, global); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Is there an explainer for this deletion, and pivoting the inputs to the _indices version? Seems like we only need to pivot the subgraph builder to use _indices; is this (and the inputs) an unrelated tidy?
Member
Author
There was a problem hiding this comment.
Remove the change from the PR.
Signed-off-by: Moritz Hoffmann <[email protected]>
frankmcsherry
approved these changes
Jan 22, 2025
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
This looks wonderful, and I appreciate the accommodation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, reachability and progress logging would use their address to identify the place where an event happened. In logging this is not great because every event needs to come with a vector. Instead, use the operator's global identifier, which we can translate back to the address using the operates events.