Move opinions about reachability logging into TrackerLogger
#629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Jan 23, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
I think we can merge the change as it moves some of the behavior specific to logging closer to the code that logs reachability events, which is a good thing. At the same time, I'm not fully convinced this is what we'll need to, say, support columnar, but that shouldn't stand in the way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very meh PR that moves some opinions about reachability logging into the
TrackerLogger, allowing the user of the logger (theTracker) to just hand over a consolidated iterator over (references to) updates. If we want to improve theTrackerLoggerto e.g. usecolumnarwhich would not require cloning the times, that is a little bit easier now.