Broadcast channels for remote processes #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
broadcastmethod toTcpAllocator's allocator implementation, such that it only sends one copy of each broadcast message to each remote process. This uses a modification toMessageHeaderto allow for a range of target worker identifiers, on the send side, and the ability to cloneByteson the receive side.The change to
MessageHeaderto allow a range of identifiers feels a bit weird, but seemed the most direct path to a broadcast channel, and not obviously the worst of many other ways we might have indicated the same. If we learn more about sending to subsets of remote workers, or need to economize on message header size, we can revisit!This should result in a factor
#workers/#processesreduction in progress traffic sent between processes.