Use broadcast channel for the broadcast operator #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timely recently gained a broadcast channel. This change switches the broadcast operator to using the broadcast channel. It also tests that Arc can be broadcasted. This requires us to enable the "rc" feature on serde. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Member
Author
|
Tests should be green after #677. |
antiguru
changed the title
Member
Author
|
Unfortunately this is not correct. In its current form it'd confuse progress tracking as each count on the input appears worker-times on the output. It's not a simple fix to change this, as we count before handing data off to a Closing the PR because more work is necessary to enable this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timely recently gained a broadcast channel. This change switches the broadcast operator to using the broadcast channel. It also tests that Arc can be broadcasted.
This requires us to enable the "rc" feature on serde.