📌 Setup to Install openslide-binaries using pip#936
Merged
shaneahmed merged 13 commits intodevelopfrom May 16, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #936 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 71 71
Lines 8933 8933
Branches 1170 1170
========================================
Hits 8906 8906
Misses 23 23
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets up the installation of OpenSlide binaries via pip, removing the need for manual binary downloads on Windows and simplifying installation on all platforms.
- Updates the pip package requirements to include a new OpenSlide binaries package and upgrades the OpenSlide Python package.
- Adjusts installation instructions in the documentation by removing manual OpenSlide installation steps.
- Revises GitHub workflow files to remove OpenSlide installation and version checks, and updates pip install commands to use commit SHAs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements/requirements.txt | Replaces manual OpenSlide-Python package with an updated OpenSlide binaries package and upgrades OpenSlide-Python version. |
| docs/installation.rst | Removes manual download/install instructions for OpenSlide on Windows and updates apt/brew/port commands for OpenJPEG. |
| .github/workflows/python-package.yml | Removes OpenSlide installation and version checking commands in favor of only installing OpenJPEG. |
| .github/workflows/pip-install.yml | Updates install commands to reference commit SHA instead of branch name and removes OpenSlide installation steps. |
Comments suppressed due to low confidence (2)
requirements/requirements.txt:19
- Verify that the package name 'openslide-bin' is correct and consistent with the intended pip package for OpenSlide binaries, as it differs from the traditional 'openslide-python'.
openslide-bin>=4.0.0.2
.github/workflows/pip-install.yml:60
- [nitpick] Using '${GITHUB_SHA}' instead of '${GITHUB_REF_NAME}' changes the version pinning approach; please confirm that pinning to a commit SHA is intentional for predictable builds during pull requests.
run: python -m pip install git+https://github.com/TissueImageAnalytics/tiatoolbox@${GITHUB_SHA}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openslide-binariesusingpipThis will remove the requirement to manually download openslide binaries and copy them to a specific folder on Windows.
It also improves setting up tiatoolbox on all platforms.