Skip to content

Conversation

@shaneahmed
Copy link
Member

  • Setup to Install openslide-binaries using pip

This will remove the requirement to manually download openslide binaries and copy them to a specific folder on Windows.
It also improves setting up tiatoolbox on all platforms.

@shaneahmed shaneahmed self-assigned this May 16, 2025
@shaneahmed shaneahmed added enhancement New feature or request dev tools Changes/Updates in Development tools dependencies Pull requests that update a dependency file labels May 16, 2025
@shaneahmed shaneahmed added this to the Release v1.7.0 milestone May 16, 2025
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (fa4efbd) to head (67875fe).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #936   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files           71       71           
  Lines         8933     8933           
  Branches      1170     1170           
========================================
  Hits          8906     8906           
  Misses          23       23           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shaneahmed shaneahmed merged commit 78d519a into develop May 16, 2025
3 checks passed
@shaneahmed shaneahmed deleted the dev-update-openslide-bin branch May 16, 2025 15:46
@Jiaqi-Lv Jiaqi-Lv requested a review from Copilot May 23, 2025 09:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up the installation of OpenSlide binaries via pip, removing the need for manual binary downloads on Windows and simplifying installation on all platforms.

  • Updates the pip package requirements to include a new OpenSlide binaries package and upgrades the OpenSlide Python package.
  • Adjusts installation instructions in the documentation by removing manual OpenSlide installation steps.
  • Revises GitHub workflow files to remove OpenSlide installation and version checks, and updates pip install commands to use commit SHAs.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
requirements/requirements.txt Replaces manual OpenSlide-Python package with an updated OpenSlide binaries package and upgrades OpenSlide-Python version.
docs/installation.rst Removes manual download/install instructions for OpenSlide on Windows and updates apt/brew/port commands for OpenJPEG.
.github/workflows/python-package.yml Removes OpenSlide installation and version checking commands in favor of only installing OpenJPEG.
.github/workflows/pip-install.yml Updates install commands to reference commit SHA instead of branch name and removes OpenSlide installation steps.
Comments suppressed due to low confidence (2)

requirements/requirements.txt:19

  • Verify that the package name 'openslide-bin' is correct and consistent with the intended pip package for OpenSlide binaries, as it differs from the traditional 'openslide-python'.
openslide-bin>=4.0.0.2

.github/workflows/pip-install.yml:60

  • [nitpick] Using '${GITHUB_SHA}' instead of '${GITHUB_REF_NAME}' changes the version pinning approach; please confirm that pinning to a commit SHA is intentional for predictable builds during pull requests.
run: python -m pip install git+https://github.com/TissueImageAnalytics/tiatoolbox@${GITHUB_SHA}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file dev tools Changes/Updates in Development tools enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants