Skip to content

Conversation

@Jiaqi-Lv
Copy link
Collaborator

@Jiaqi-Lv Jiaqi-Lv commented May 23, 2025

This PR refines the dependency version requirements by pinning tifffile with an explicit upper bound.

  • Pin tifffile with both a minimum version (2022.10.10) and maximum version (2025.5.10).
  • This ensures controlled compatibility for tifffile across environments.

@Jiaqi-Lv Jiaqi-Lv self-assigned this May 23, 2025
@Jiaqi-Lv Jiaqi-Lv added the dependencies Pull requests that update a dependency file label May 23, 2025
@shaneahmed shaneahmed added this to the Release v1.7.0 milestone May 23, 2025
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (78d519a) to head (60cc3b6).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #937   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files           71       71           
  Lines         8933     8933           
  Branches      1170     1170           
========================================
  Hits          8906     8906           
  Misses          23       23           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiaqi-Lv Jiaqi-Lv requested a review from Copilot May 23, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the dependency version requirements by pinning tifffile with an explicit upper bound.

  • Pin tifffile with both a minimum version (2022.10.10) and maximum version (2025.5.10).
  • This ensures controlled compatibility for tifffile across environments.

SimpleITK>=2.2.1
sphinx>=5.3.0
tifffile>=2022.10.10
tifffile>=2022.10.10, <=2025.5.10
Copy link

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing the extra space after the comma to match the formatting of other dependency lines.

Suggested change
tifffile>=2022.10.10, <=2025.5.10
tifffile>=2022.10.10,<=2025.5.10

Copilot uses AI. Check for mistakes.
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed merged commit 6ecb9e9 into develop May 23, 2025
39 checks passed
@shaneahmed shaneahmed deleted the pin-tiffile-version branch May 23, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants