Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #937 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 71 71
Lines 8933 8933
Branches 1170 1170
========================================
Hits 8906 8906
Misses 23 23
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the dependency version requirements by pinning tifffile with an explicit upper bound.
- Pin tifffile with both a minimum version (2022.10.10) and maximum version (2025.5.10).
- This ensures controlled compatibility for tifffile across environments.
| SimpleITK>=2.2.1 | ||
| sphinx>=5.3.0 | ||
| tifffile>=2022.10.10 | ||
| tifffile>=2022.10.10, <=2025.5.10 |
There was a problem hiding this comment.
[nitpick] Consider removing the extra space after the comma to match the formatting of other dependency lines.
Suggested change
| tifffile>=2022.10.10, <=2025.5.10 | |
| tifffile>=2022.10.10,<=2025.5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the dependency version requirements by pinning tifffile with an explicit upper bound.