Skip to content

Conversation

@Jiaqi-Lv
Copy link
Collaborator

Fixed typing issue in pyramid.py.

@Jiaqi-Lv Jiaqi-Lv changed the title :hammer mypy fix typing in pyramid.py 🔧 mypy fix typing in pyramid.py May 30, 2025
@Jiaqi-Lv Jiaqi-Lv changed the title 🔧 mypy fix typing in pyramid.py 🔧 'mypy' fix typing in pyramid.py May 30, 2025
@Jiaqi-Lv Jiaqi-Lv changed the title 🔧 'mypy' fix typing in pyramid.py 🔧 mypy fix typing in pyramid.py May 30, 2025
@Jiaqi-Lv Jiaqi-Lv self-assigned this May 30, 2025
@Jiaqi-Lv Jiaqi-Lv added the dev tools Changes/Updates in Development tools label May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (6b4a75a) to head (ebcff56).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #938   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files           71       71           
  Lines         8934     8934           
  Branches      1171     1171           
========================================
  Hits          8907     8907           
  Misses          23       23           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiaqi-Lv Jiaqi-Lv marked this pull request as ready for review June 6, 2025 11:22
@Jiaqi-Lv Jiaqi-Lv requested a review from Copilot June 6, 2025 11:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a mypy typing issue in pyramid.py while also updating related configuration files for consistency.

  • Updated import in pyramid.py to include Literal for improved type annotation.
  • Added explicit type annotations to the compression2mode variable and adjusted the tarfile open call for type compatibility.
  • Updated mypy version in requirements and adjusted the workflow file accordingly.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tiatoolbox/tools/pyramid.py Fixed type annotations and ensured tarfile.TarFile.open receives a string path.
requirements/requirements_dev.txt Upgraded mypy version for improved type checking support.
.github/workflows/mypy-type-check.yml Minor adjustment to file paths in the type check workflow.

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed merged commit b18f83a into develop Jun 9, 2025
27 checks passed
@shaneahmed shaneahmed deleted the mypy-fix-tools branch June 9, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev tools Changes/Updates in Development tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants