-
Notifications
You must be signed in to change notification settings - Fork 102
🔧 mypy fix typing in pyramid.py
#938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mypy fix typing in pyramid.pymypy fix typing in pyramid.py
mypy fix typing in pyramid.pypyramid.py
pyramid.pymypy fix typing in pyramid.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #938 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 71 71
Lines 8934 8934
Branches 1171 1171
========================================
Hits 8907 8907
Misses 23 23
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a mypy typing issue in pyramid.py while also updating related configuration files for consistency.
- Updated import in pyramid.py to include Literal for improved type annotation.
- Added explicit type annotations to the compression2mode variable and adjusted the tarfile open call for type compatibility.
- Updated mypy version in requirements and adjusted the workflow file accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tiatoolbox/tools/pyramid.py | Fixed type annotations and ensured tarfile.TarFile.open receives a string path. |
| requirements/requirements_dev.txt | Upgraded mypy version for improved type checking support. |
| .github/workflows/mypy-type-check.yml | Minor adjustment to file paths in the type check workflow. |
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jiaqi-Lv
Fixed typing issue in
pyramid.py.