Skip to content

Conversation

@Jiaqi-Lv
Copy link
Collaborator

@Jiaqi-Lv Jiaqi-Lv commented Sep 2, 2025

  • Update type annotations in the utils/misc.py file to improve mypy compliance

@shaneahmed shaneahmed added the bug Something isn't working label Sep 2, 2025
@shaneahmed shaneahmed added this to the Release v1.7.0 milestone Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (318aa32) to head (28e8f1e).
⚠️ Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
- Coverage    99.70%   99.68%   -0.03%     
===========================================
  Files           71       71              
  Lines         9141     9142       +1     
  Branches      1190     1190              
===========================================
- Hits          9114     9113       -1     
- Misses          23       25       +2     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shaneahmed shaneahmed changed the title MyPy Update Typing in utils.py mypy Update Typing in utils.py Sep 5, 2025
@shaneahmed shaneahmed marked this pull request as ready for review September 5, 2025 10:06
@Jiaqi-Lv Jiaqi-Lv requested a review from Copilot September 5, 2025 10:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates type annotations in the utils/misc.py file to improve mypy compliance. The changes include adding the cast import and fixing type annotations for better type checking.

  • Adds cast import from the typing module
  • Updates zarr.group to the correct zarr.Group type annotation
  • Adds explicit type casting for contours variable to resolve mypy warnings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed changed the title mypy Update Typing in utils.py 🏷️ mypy Update Typing in utils.py Sep 12, 2025
@shaneahmed shaneahmed merged commit 5ccbc70 into develop Sep 12, 2025
14 of 15 checks passed
@shaneahmed shaneahmed deleted the mypy-update-utils branch September 12, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants