-
Notifications
You must be signed in to change notification settings - Fork 102
🏷️ mypy Update Typing in utils.py
#951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #951 +/- ##
===========================================
- Coverage 99.70% 99.68% -0.03%
===========================================
Files 71 71
Lines 9141 9142 +1
Branches 1190 1190
===========================================
- Hits 9114 9113 -1
- Misses 23 25 +2
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
utils.pymypy Update Typing in utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates type annotations in the utils/misc.py file to improve mypy compliance. The changes include adding the cast import and fixing type annotations for better type checking.
- Adds
castimport from thetypingmodule - Updates
zarr.groupto the correctzarr.Grouptype annotation - Adds explicit type casting for
contoursvariable to resolve mypy warnings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jiaqi-Lv
mypy Update Typing in utils.pymypy Update Typing in utils.py
utils/misc.pyfile to improve mypy compliance