Skip to content

Fix GitHub API Jackson conflict by isolating dependency #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
modwodmm wants to merge 2 commits into from
Closed

Fix GitHub API Jackson conflict by isolating dependency #1333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
534917b
Fix GitHub API Jackson conflict by isolating dependency
modwodmm Oct 13, 2025
569fbf7
Fix Jackson dependency conflict
modwodmm Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion application/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ dependencies {

implementation 'com.github.ben-manes.caffeine:caffeine:3.2.0'

implementation 'org.kohsuke:github-api:1.329'
implementation('org.kohsuke:github-api:1.326') {
exclude group: 'com.fasterxml.jackson.core'
exclude group: 'com.fasterxml.jackson.datatype'
exclude group: 'com.fasterxml.jackson.dataformat'
exclude group: 'com.fasterxml.jackson.module'
Comment on lines +79 to +82
Copy link
Member

@Zabuzard Zabuzard Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an indentation (or run spotless)

Copy link
Author

@modwodmm modwodmm Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ran gradlew.bat run and it ran without any error and showed build successful

Copy link
Author

@modwodmm modwodmm Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an indentation (or run spotless)

ran spotless as well

Copy link
Member

@Zabuzard Zabuzard Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ran gradlew.bat run and it ran without any error and showed build successful

thats not enough though. u need to actually run the bot, connect it to your local test server and for example use the /ping command successfully :)

the compilation worked before already as well.
and u need to check it with the updated dependency as the error doesnt occur beforehand anyways.

Copy link
Member

@Zabuzard Zabuzard Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess spotless doesnt run on the gradle file then. either case, please add indents, thanks

Copy link
Member

@Zabuzard Zabuzard Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the jackson dependency to provoke the problematic setup. The current versions never created any problems to begin with. See the ticket description again and the linked jackson update :)

}


implementation 'org.apache.commons:commons-text:1.14.0'
implementation 'com.apptasticsoftware:rssreader:3.10.0'
Expand Down