Feat/help thread stats #1361
Open
Feat/help thread stats #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces fetching metrics directly from database instead of discord, uses embed for showcases stats and making duration as optional choice in terms of days
spotless fixes, helper for calculating duration in seconds between datetime fields to be more compliant with code quality tests
change emojis to unicode character constants with descriptive names, single/blank line of space to be more intentional and clear
tj-wazei
requested changes
Dec 30, 2025
Contributor
tj-wazei
left a comment
tj-wazei
left a comment
There was a problem hiding this comment.
I think this is fine, just some small changes to the imports.
application/src/main/java/org/togetherjava/tjbot/features/Features.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Outdated
Show resolved
Hide resolved
SquidXTV
requested changes
Jan 5, 2026
Member
SquidXTV
left a comment
SquidXTV
left a comment
There was a problem hiding this comment.
Good job!
I kinda abused some review comments for future ideas and questions.
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Show resolved
Hide resolved
…/HelpThreadStatsCommand.java use a more simpler way to get days and a fallback if user entered option is missing Co-authored-by: Connor Schweighöfer <[email protected]>
since when saving thread meta data, participant count excludes author which means thread with 0 participants should be counted as ghost threads instead of single participant
to avoid users from spamming, this adds a cooldown period of a min per channel
SquidXTV
requested changes
Jan 5, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java
Outdated
Show resolved
Hide resolved
uses Duration instance for expiration of cache items instead of seperate values for ease of maintenance and clarity
SquidXTV
approved these changes
Jan 5, 2026
Zabuzard
requested changes
Jan 7, 2026
Comment on lines
+59
to
+65
| private static final String EMOJI_CHART = "\uD83D\uDCCA"; | ||
| private static final String EMOJI_MEMO = "\uD83D\uDCDD"; | ||
| private static final String EMOJI_SPEECH_BUBBLE = "\uD83D\uDCAC"; | ||
| private static final String EMOJI_LABEL = "\uD83C\uDFF7\uFE0F"; | ||
| private static final String EMOJI_LIGHTNING = "\u26A1"; | ||
|
|
||
| private static final String EMBED_BLANK_LINE = "\u200B"; |
Member
There was a problem hiding this comment.
please prefer having the actual UTF-8 emoji characters here, so the source code is readable.
| } | ||
|
|
||
| @Override | ||
| public void onSlashCommand(SlashCommandInteractionEvent event) { |
Member
There was a problem hiding this comment.
that method is quite long. think about breaking it into maybe 2 or 3 helper methods? looks like there is a clear structure with: handle cooldown, database management, create and send response
Comment on lines
+211
to
+216
| if (rawResRate >= 70) | ||
| return Color.GREEN; | ||
| if (rawResRate >= 30) | ||
| return Color.YELLOW; | ||
| if (rawResRate >= 0) | ||
| return Color.RED; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues work of #1159 with /help-stats slash command, refactors to fetch stats from database instead of discord APIs. Also adds stats to embed for better UX.
embed color has three states
edited: also adds per channel limit, can be used once per minute.