Fix search and pinned button#930
Merged
TokisanGames merged 3 commits intoTokisanGames:asset_dock_46from Feb 2, 2026
Merged
Conversation
Owner
|
Thank you. I'll bring it into my PR and work on it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the search function in the asset dock in 4.6
For some reason, the asset dock is not fully initialized when _ready() is called - and _ready() exits early in this case, so the text_changed and button press signal connections, and the icon set up was being skipped. I moved all of this to the initialize function.
The pinned button - the asset dock was not finding a Window as grandparent therefore thought it was still docked - the new structure seems to have added another layer so now we need to look for the great-grandparent!
Added a check so that we can reset the window variable to null if we are docked and use the validity of the window object to determine whether the pin button should be visible or not.