Skip to content

Conversation

@DenishKakadiya
Copy link

#2606

  • replaced 50 with 100 to properly calculate determinate_value from determinate_speed value.

This change will correct wierd output of determinate_value for each step increament.

replaced 50 with 100 to properly calculate determinate_value from determinate_speed value.
@FedericoSpada
Copy link
Collaborator

Hi,
I think that the division by 50 is because _internal_loop() is called every 20ms, so that determinate_speed and indeterminate_speed can be considered to have [%/s] as unit of measurement.

In case we call step() manually, that unit of measurement is no longer applicable. For this reason, I would suggest creating a new separated parameter (called, for example, "step_increment") that will be used just when the step() method is invoked. Its unit of measurement would be [%], and it would be used as is without any other division.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants