Relax numpy versions #2156
Merged
Relax numpy versions #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
requested changes
May 9, 2025
hrobarts
reviewed
May 9, 2025
Contributor
There was a problem hiding this comment.
Hi this looks useful to me so think it would be useful to have it somewhere shared, maybe could move it to the new build scripts repo? https://github.com/TomographicImaging/Build-scripts
hrobarts
approved these changes
Jul 15, 2025
Merged
casperdcl
added a commit
that referenced
this pull request
Aug 5, 2025
casperdcl
added a commit
that referenced
this pull request
Aug 14, 2025
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156) - fix: collect distributions in one job for upload & reindex (fixes #1918) - optimise + share one build (per OS/Python version) across multiple numpy versions + per PR: min py/np version, ubuntu + `master`: min & max py/np, all OS + `tag` or `workflow_dispatch`: all versions, all OS
casperdcl
added a commit
that referenced
this pull request
Aug 14, 2025
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156) - fix: collect distributions in one job for upload & reindex (fixes #1918) - optimise + share one build (per OS/Python version) across multiple numpy versions + per PR: min py/np version, ubuntu + `master`: min & max py/np, all OS + `tag` or `workflow_dispatch`: all versions, all OS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This relaxes our numpy requirements as we don't need to build against a specific version.
I've added a convenience script that will build and test each version combination locally on windows or linux.
Follow-ups #2090 #2091 will recommend installing via environment files, or checking the tested version table.
Testing you performed
Related issues/links
closes #2092
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.