-
Notifications
You must be signed in to change notification settings - Fork 62
Added table of dependencies versions to README #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Edoardo Pasca <[email protected]>
|
Do we want to also update the conda instructions to use the env files here: Hannah has drafted something here: |
Signed-off-by: Edoardo Pasca <[email protected]>
Signed-off-by: Edoardo Pasca <[email protected]>
Signed-off-by: Edoardo Pasca <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]> Signed-off-by: Hannah Robarts <[email protected]>
Signed-off-by: Hannah Robarts <[email protected]>
Signed-off-by: Casper da Costa-Luis <[email protected]>
Signed-off-by: Casper da Costa-Luis <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]> Signed-off-by: Hannah Robarts <[email protected]>
gfardell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems very clear to me! I think it's a good change. The tested versions we can update as we iterate.
Signed-off-by: Hannah Robarts <[email protected]>
Signed-off-by: Hannah Robarts <[email protected]>
casperdcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well that was easy
Signed-off-by: Edoardo Pasca <[email protected]>
Signed-off-by: Edoardo Pasca <[email protected]>
Signed-off-by: Edoardo Pasca <[email protected]>
Description
After discussion with @hrobarts we decided to not remove the original conda install commands as the new proposed one didn't seem simple.
Also the old text made clear what the role of the additional dependencies is and even how to get ASTRA for CPU or GPU.
We added the new command pointing to the environment file with the instruction that it was installing the software necessary for CIL-Demos with tested versions.
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.