feat(perfectcue): DSAN PerfectCue network extender support - #2
Merged
Conversation
Add src/perfectcue-parser.js with pure parsePerfectCueCommand/splitOnCR functions and 9 node:test unit tests. Also adds test script to package.json and src/**/* to electron-builder files list. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
createPerfectCueServer takes injected dispatch/log/onStatus so it can be tested outside Electron. Six integration tests cover split-chunk reassembly, multi-command bursts, and connection status transitions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add state vars, startPerfectCueListener/stop/dispatch/applyPerfectCuePrefs. applyPerfectCuePrefs called at app.whenReady and after save-preferences IPC so port changes take effect immediately. stopPerfectCueListener wired into before-quit for clean shutdown. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace text-based >FORWARD/>REVERSE parser with raw byte matching. The device sends 0x0F (next), 0x1F (previous), and 0xFF (keepalive) — no CR framing. Drops splitOnCR in favour of iterating Buffer bytes directly per data event. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- main.js: replace single perfectCueServer with perfectCueServers[] array; startPerfectCueListeners(ports) opens one TCP server per port; applyPerfectCuePrefs migrates legacy perfectCuePort single value - index.html: PerfectCue panel in Advanced tab with enable checkbox and dynamic port list (+/Remove, same pattern as backup machines) - renderer.js: addPerfectCuePortRow, renderPerfectCuePortList, getPerfectCuePortsFromUi, savePerfectCuePrefs; prefs load migrates old perfectCuePort on first run Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
8 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x0F(next),0x1F(previous),0xFF(keepalive — ignored)+/Remove (same UX pattern as backup machines), Save buttonperfectCuePortvalue to the newperfectCuePortsarrayTest plan
+and Remove buttons; Save applies new port setDSAN connectedappears in debug log0xFFkeepalive packets arrive every ~5s with no spurious slide changesperfectCuePortpref migrates toperfectCuePorts: [8899]on first load🤖 Generated with Claude Code