-
Notifications
You must be signed in to change notification settings - Fork 296
Code Optimization #1018
Code Optimization #1018
Conversation
2.add @return to buildAllInOneWord Method 3.optimize copyAndReplaceDocx through extraction.
|
Thanks for your PR. 🙏 In addition, if you have added new features, please provide example code in the repository smart-doc-group/smart-doc-example-cn. This will help other users understand how to use the new features. Code Style Reminder: 感谢您提交的PR。 🙏 另外,如果您添加了新功能,请在仓库smart-doc-group/smart-doc-example-cn中提供示例代码。这将帮助其他用户了解如何使用新功能。 代码风格提示: |
linwumingshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1、 Code Style Reminder:
The code should use the Spring code style. Please format your code using the command mvn spring-javaformat:apply. You can also install the Spring Java Format plugin for convenience.
代码风格提示:
请使用 Spring 代码风格。您可以通过命令 mvn spring-javaformat:apply 格式化代码。为了方便操作,您还可以安装 Spring Java Format 插件。
2、 Commit Message Format:
To ensure consistency in commit messages, please follow these guidelines:
为了确保提交信息的规范性,请参考以下格式要求进行提交:
| /** | ||
| * replace docx content | ||
| * @param content doc content | ||
| * @param docxOutputPath docx output path | ||
| * @throws Exception exception | ||
| * @since 1.0.0 | ||
| */ | ||
| public static void copyAndReplaceDocx(String content, String docxOutputPath,String TEMPLATE_DOCX) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc is missing the description for the last parameter. Additionally, the parameter names are not following the lower camel case convention. Please update the parameter names to use the correct naming style and add a description for the last parameter.
|
close |
1.delete template.docx
2.add
@returnto buildAllInOneWord Method3.optimize copyAndReplaceDocx through extraction.