Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

Conversation

@zlxs1317169
Copy link
Contributor

@zlxs1317169 zlxs1317169 commented Jan 17, 2025

1.delete template.docx
2.add @return to buildAllInOneWord Method
3.optimize copyAndReplaceDocx through extraction.

2.add  @return to buildAllInOneWord Method
3.optimize copyAndReplaceDocx through extraction.
@github-actions
Copy link

Thanks for your PR. 🙏
Please check again for your PR changes whether they contain any usage configuration change, such as Add new configuration or Change default value of configuration.
If so, please add or update documents (Markdown format) in the docs/ directory of the repository smart-doc-group/smart-doc-group.github.io.

In addition, if you have added new features, please provide example code in the repository smart-doc-group/smart-doc-example-cn. This will help other users understand how to use the new features.

Code Style Reminder:
The code should use the Spring code style. Please format your code using the command mvn spring-javaformat:apply. You can also install the Spring Java Format plugin for convenience.


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式或配置参数的变更,如:新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库smart-doc-group/smart-doc-group.github.io中的docs/目录下添加或更新文档(Markdown格式)。

另外,如果您添加了新功能,请在仓库smart-doc-group/smart-doc-example-cn中提供示例代码。这将帮助其他用户了解如何使用新功能。

代码风格提示:
请使用 Spring 代码风格。您可以通过命令 mvn spring-javaformat:apply 格式化代码。为了方便操作,您还可以安装 Spring Java Format 插件。

Copy link
Collaborator

@linwumingshi linwumingshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zlxs1317169

1、 Code Style Reminder:
The code should use the Spring code style. Please format your code using the command mvn spring-javaformat:apply. You can also install the Spring Java Format plugin for convenience.

代码风格提示:
请使用 Spring 代码风格。您可以通过命令 mvn spring-javaformat:apply 格式化代码。为了方便操作,您还可以安装 Spring Java Format 插件。


2、 Commit Message Format:

To ensure consistency in commit messages, please follow these guidelines:

为了确保提交信息的规范性,请参考以下格式要求进行提交:

Comment on lines +1822 to +1829
/**
* replace docx content
* @param content doc content
* @param docxOutputPath docx output path
* @throws Exception exception
* @since 1.0.0
*/
public static void copyAndReplaceDocx(String content, String docxOutputPath,String TEMPLATE_DOCX) throws Exception {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Javadoc is missing the description for the last parameter. Additionally, the parameter names are not following the lower camel case convention. Please update the parameter names to use the correct naming style and add a description for the last parameter.

@zlxs1317169
Copy link
Contributor Author

close

@zlxs1317169 zlxs1317169 deleted the codeoptimize branch January 24, 2025 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants