Add playPreview method to Track object #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/track.js
Outdated
Owner
There was a problem hiding this comment.
This emit call will happen before the user has a chance to attach an "error" listener to the stream (since it hasn't been returned yet). Let's call this in a process.nextTick() callback.
Collaborator
Author
There was a problem hiding this comment.
Both this and the other comment are fixed in 3dd517e. I never realised why everyone used process.nextTick for emitting events but now that you explain it, that makes a lot of sense. Thanks.
…ror on stream in nextTick
TooTallNate
added a commit
that referenced
this pull request
Aug 18, 2013
Add playPreview method to Track object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory, provides a new method to play previews and an example which uses it.
From the earlier conversation in #23. The code hasn't changed since then - just submitting it as a PR so it doesn't get forgotten.