-
Notifications
You must be signed in to change notification settings - Fork 0
Feature retention period support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rschouten97
wants to merge
24
commits into
main
Choose a base branch
from
feature-retention-period-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to blacklist table
…alue reuse after deletion
…s and feature descriptions
Contributor
Author
|
de auditlog is nog niet op orde. review kan wachten. |
Contributor
Author
|
ook de logging gaat nu goed en de uniquenessCheck voor AD is ook meteen gecorrigeerd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Enhancement: V2.0.0 - Align SQL Blacklist Connector with CSV Connector and V2 Standards
Summary
This PR brings the SQL blacklist connector to feature parity with the CSV blacklist connector while implementing retention period support, cross-check validation, and adherence to Tools4ever V2 connector standards.
Motivation
The SQL blacklist connector was missing several critical features present in the CSV variant, including retention period logic, cross-attribute validation, and field synchronization. Additionally, the documentation and structure didn't follow the V2 template standards.
Key Changes
🚀 New Features
crossCheckOnconfiguration to validate uniqueness across different attribute types (e.g., checking if an email exists as a proxy address)OtherEmployeeIdandMultipleFoundwith detailed error messages🔧 Core Script Improvements
📝 Configuration & Mapping
whenCreated,whenUpdated,whenDeletedcolumns with datetime2(7) precision📚 Documentation
🐛 Bug Fixes
whenDeletedandwhenUpdatedfieldsBreaking Changes
retentionPeriodparameter is now required in configurationwhenDeletedfield removed from fieldMapping.json (managed internally)Testing Recommendations
Migration Notes
For existing implementations:
retentionPeriodto configuration (recommended: 365 days)createTableBlacklist.sqlto add timestamp columns if upgrading from v1.0.0whenDeletedfrom field mapping if present