Add the initial playbook handler from GoDaddy#15
Open
krislindgren wants to merge 1 commit intoToolsForHumans:masterfrom
Open
Add the initial playbook handler from GoDaddy#15krislindgren wants to merge 1 commit intoToolsForHumans:masterfrom
krislindgren wants to merge 1 commit intoToolsForHumans:masterfrom
Conversation
This includes all sorts of GD specific refrences that need to be refactored, but at least a base handler is here now.
Contributor
|
How about we kick all the GD stuff out first :) |
Contributor
|
(honestly there isn't alot to kick out, would just be nice to d o that now vs later). |
Contributor
|
Actually, I guess there isn't that much GD stuff, just some kolla stuff. |
harlowja
reviewed
Nov 8, 2018
| return vault_path | ||
|
|
||
|
|
||
| def generate_cloud_inventories(config): |
Contributor
There was a problem hiding this comment.
Can we cut this out somehow?
harlowja
reviewed
Nov 8, 2018
| return inventories | ||
|
|
||
|
|
||
| def generate_kolla_ansible_extra_vars(working_dir, |
harlowja
reviewed
Nov 8, 2018
| if not enabled: | ||
| return False | ||
| all_found = utils.can_find_all_executables( | ||
| ["ansible-playbook", 'render-ansible', 'git'], logger=LOG) |
Contributor
There was a problem hiding this comment.
What's 'render-ansible' ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all sorts of GD specific refrences that need to be
refactored, but at least a base handler is here now.