Selection widget for theories #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
requested changes
Oct 18, 2024
Member
epatters
left a comment
epatters
left a comment
There was a problem hiding this comment.
Thanks Hamidah, this is starting to look quite good!
I would divide the existing theories as:
- Knowledge and data
- Ologs
- Schemas
- Life sciences
- Regulatory networks
- System dynamics
- Causal loop diagrams
- Stock and flow
Regarding the styling:
- As you click different theories, the menu jumps around the screen, which is a surprising behavior
- IMO, menu items need slightly more spacing between them
epatters
reviewed
Nov 7, 2024
epatters
requested changes
Nov 8, 2024
Member
epatters
left a comment
epatters
left a comment
There was a problem hiding this comment.
Thanks Hamidah, the widget looks wonderful! I've suggested some ways to improve the code.
hamidahoderinwale
force-pushed
the
theoryselection
branch
2 times, most recently
from
3ffef13 to
e942bd8
Compare
epatters
added
enhancement
epatters
force-pushed
the
theoryselection
branch
3 times, most recently
from
622aba3 to
73c2c8c
Compare
epatters
force-pushed
the
theoryselection
branch
from
73c2c8c to
5841fd0
Compare
Also, refactor the dialog to not depend on the whole Automerge document.
epatters
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
Selection widget. Theory shows upon selection, division category for organization.